Bugfix #7827 - Fixed incorrect status code and error message when rate own event. #7855
+111
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viceImpl; Replaced restTemplate to userRepo for finding userByEmail in rateEvent() method in EventServiceImpl; Added error message constant 'Organizer have no rights to rate the own event' into ErrorMessages class; Created missed unit tests for rateEvent() method for EventServiceImpl class; Added method getEventNotStartedYet() for creating not started event yet into ModelUtils class;
service/src/test/java/greencity/service/EventServiceImplTest.java
Outdated
Show resolved
Hide resolved
Maryna-511750
approved these changes
Dec 3, 2024
KizerovDmitriy
approved these changes
Dec 3, 2024
|
urio999
approved these changes
Dec 3, 2024
ChernenkoVitaliy
deleted the
bug/7827-wrong-status-code-and-message-when-rate-own-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GreenCity PR
Issue Link 📋
https://github.com/orgs/ita-social-projects/projects/44/views/1?pane=issue&itemId=89331619&issue=ita-social-projects%7CGreenCity%7C7827
Added
Changed
Summary Of Changes 🔥
Improvement according to task https://github.com/orgs/ita-social-projects/projects/44/views/1?pane=issue&itemId=89331619&issue=ita-social-projects%7CGreenCity%7C7827;
Improved test coverage for rateEvent() method for EventServiceImpl class(covered 100%);